Skip to content

FIX solve wrong indexing in plots with ICE when subsampling #18359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 30, 2020
Merged

FIX solve wrong indexing in plots with ICE when subsampling #18359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
663d526
STY rename some variable with explicit name
glemaitre Sep 8, 2020
ce421ec
FIX correct the indexing in ICE
glemaitre Sep 8, 2020
4a66b2c
TST add non-regression test
glemaitre Sep 8, 2020
d4b1eb1
iter
glemaitre Sep 8, 2020
4976469
review thomas
glemaitre Sep 10, 2020
a0dce1c
some refactoring
glemaitre Oct 8, 2020
e01d975
unravel the labels to avoid raveling array
glemaitre Oct 8, 2020
921be4d
more unravel indexing
glemaitre Oct 8, 2020
bff18b4
refactor into 1-way 2-way PDP
glemaitre Oct 8, 2020
5ab37a5
remove useless import
glemaitre Oct 8, 2020
a3ec56e
iter
glemaitre Oct 8, 2020
43ac791
iter
glemaitre Oct 8, 2020
cd845a3
add documentation and further refactoring
glemaitre Oct 8, 2020
12827bc
apply comments ogrisel
glemaitre Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/inspection/plot_partial_dependence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
features = ['MedInc', 'AveOccup', 'HouseAge', 'AveRooms']
display = plot_partial_dependence(
est, X_train, features, kind="both", subsample=50,
n_jobs=3, grid_resolution=20
n_jobs=3, grid_resolution=20, random_state=0
)
print(f"done in {time() - tic:.3f}s")
display.figure_.suptitle(
Expand Down Expand Up @@ -161,7 +161,7 @@
tic = time()
display = plot_partial_dependence(
est, X_train, features, kind="both", subsample=50,
n_jobs=3, grid_resolution=20
n_jobs=3, grid_resolution=20, random_state=0
)
print(f"done in {time() - tic:.3f}s")
display.figure_.suptitle(
Expand Down
Loading