FIX VisibleDeprecationWarning in unit tests and docstrings #18414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2020 23:25
cmarmo
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Thanks @OlehKSS for your PR. LGTM for me.
However, I'm wondering if the _to_object_array function is still necessary now that np.array ask for a dtype parameter. We might want to open an issue about that after this PR merged.
|
Ping @glemaitre, if you have sometime to have a look. I think this is worth to have a place in 0.24 because it removes deprecations from numpy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #18367
What does this implement/fix? Explain your changes.
Fix
numpy.VisibleDeprecationWarningintest_multilabel_binarizer_non_integer_labels, caused by an implicit conversion of a ragged nested sequence tonumpy.ndarray.Numpy's message:
numpy.VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray
Also, fix
numpy.VisibleDeprecationWarningin the _to_object_array docstring tests.