MNT Don't validate error messages when strict mode is off #18415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2020
jnothman
reviewed
Sep 23, 2020
jnothman
approved these changes
Sep 23, 2020
rth
reviewed
Sep 23, 2020
| ) | ||
|
|
||
|
|
||
| def test_check_fit2d_1feature(): |
There was a problem hiding this comment.
That's exactly the same function as above?
There was a problem hiding this comment.
almost, but for different checks ;)
one checks samples the other checks features
|
Good to merge @rth? ;) |
NicolasHug
added a commit
to NicolasHug/scikit-learn
that referenced
this pull request
Sep 28, 2020
…ikit-learn#18415)" This reverts commit a49032c.
amrcode
pushed a commit
to amrcode/scikit-learn
that referenced
this pull request
Oct 19, 2020
…rn#18415) in check_estimator
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…rn#18415) in check_estimator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13969
This PR makes
check_estimator(strict_mode=False)not validate the exact error message. The type of the exceptions is however still enforced.Still left to do: docs and whatsnew entry (will do that in another PR, probably)
It would be better to have #18418 merged first