ENH Incremental weighted mean and var #18447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
approved these changes
Sep 24, 2020
|
I am wondering if I should add an entry in whatsnew, even if the function is private. |
rth
reviewed
Sep 30, 2020
There was a problem hiding this comment.
Thanks @albertvillanova ! One minor comment otherwise LGTM. I think we will be able to add a what's new (with contributors to this PR as well) once we start using this in StandardScaler (#15601)
rth
approved these changes
Oct 1, 2020
amrcode
pushed a commit
to amrcode/scikit-learn
that referenced
this pull request
Oct 19, 2020
Co-authored-by: Piotr Gaiński <dociebieaniuszlem@gmail.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Co-authored-by: Piotr Gaiński <dociebieaniuszlem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #15601.
Supersede and close #16066.