Skip to content

[WIP] online matrix factorization with missing values #18492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

TwsThomas
Copy link
Contributor

@TwsThomas TwsThomas commented Sep 29, 2020

What does this implement/fix? Explain your changes.

Allow dict_learning_online to handles nan

todo

  • add tests
  • add minibatch
  • documentation
  • support custom missing value marker
  • partial fit
  • transform
  • write an example

Any other comments?

Adapted from "Online Group-Structured Dictionary Learning " by Z. Szabo, B. Poczos, A. Lörnicz, 2011

The benchmarks are as follow:
The execution time of dict_learning_na is similar on small dataset w.r.t. dict_learning_online
time

The loss is also comparable to dict_learning_online
loss

The reconstruction of missing values is compared with KNN, SoftImpute and IterativeSVD from fancyimpute. On the digits dataset
digits_reconstruction

@GaelVaroquaux GaelVaroquaux changed the title [WIP] handles Nan in dict learning online [WIP] online matrix factorization with missing values Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants