MNT Uses a less strict error message for n_features_in_ checks #18585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
approved these changes
Oct 12, 2020
|
@NicolasHug Are you okay with this change? |
|
I was thinking that having the estimator's name in the error message is useful precisely in the case of meta-estimators. No strong opinion anyway |
I am okay with this as well. Then we adjust the test: scikit-learn/sklearn/utils/estimator_checks.py Lines 3177 to 3178 in fdb9233 to accept any name for the class name? |
|
sure, this sounds good too |
ogrisel
approved these changes
Oct 14, 2020
amrcode
pushed a commit
to amrcode/scikit-learn
that referenced
this pull request
Oct 19, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #18578 (comment)
What does this implement/fix? Explain your changes.
This PR updates the error message to not include the estimator name. This allows meta estimators to delegate to inner estimators and output a more generic error message.
Any other comments?
An alternative would be to catch the exception check its message and change the estimator name to the met estimator. This seems heavy handed.
CC @ogrisel