EXA use class instead of function for preprocessing in plot_kmeans_digits #18657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Oct 29, 2020
| ) | ||
|
|
||
| bench_k_means( | ||
| kmeans=KMeans( |
There was a problem hiding this comment.
I see the advantage of black for library code, but for example code or any type of teaching material I find it harder to read. Having lines span horizontally feels more "human readable"
But this could be just me. I wonder what every one else thinks.
There was a problem hiding this comment.
I made the example more compact.
thomasjpfan
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up of #18327
Use class instead of preprocessing function to scale data in example gallery.
During this adjustment, the examples are transformed into notebook-style for a better rendering.