Skip to content

MAINT Try to fix [icc-build] in travis (+doc) #18730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2020
Merged

MAINT Try to fix [icc-build] in travis (+doc) #18730

merged 4 commits into from
Nov 2, 2020

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Nov 2, 2020

It seems that Intel has renamed a file that made the travis cron-job fail as a result.

@ogrisel ogrisel requested a review from jeremiedbb November 2, 2020 11:27
@ogrisel ogrisel changed the title Try to fix [icc-build] in travis (+doc) MAINT Try to fix [icc-build] in travis (+doc) Nov 2, 2020
@ogrisel
Copy link
Member Author

ogrisel commented Nov 2, 2020

Ok the build now works but the test are terminated:

$ source build_tools/travis/install.sh
[...]
$ bash build_tools/travis/test_script.sh || travis_terminate 1
Python 3.7.9
numpy 1.20.0.dev0+5c37621
scipy 1.6.0.dev0+e31707a
pandas 1.2.0.dev0+1025.g821f90c23
2 CPUs
x86_64
:: WARNING: setvars.sh has already been run. Skipping re-execution.
   To force a re-execution of setvars.sh, use the '--force' option.
   Using '--force' can result in excessive use of your environment variables.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 2, 2020

The build now fails with the same problem as the numpy dev CRON jobs:

https://travis-ci.org/github/scikit-learn/scikit-learn/builds/740838278?utm_source=github_status&utm_medium=notification

Apparently we are missing explicit casts. @alfaro96 I remember you were working on fixing those but I cannot find your PR. I can only find #18654 (comment).

@ogrisel
Copy link
Member Author

ogrisel commented Nov 2, 2020

Hum found it: #18711. I must have made a typo in my first keyword search.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 2, 2020

Ok let me merge this, the remaining failures will be fixed in dedicated PRs such as #18711.

@ogrisel ogrisel merged commit 7b3e2c0 into scikit-learn:master Nov 2, 2020
@ogrisel ogrisel deleted the intel-oneapi-build branch November 2, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb Awaiting requested review from jeremiedbb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ogrisel