Skip to content

MAINT update flake8 config on circleci linter #18731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Nov 2, 2020

Follow-up for #18724. I had forgotten to update the circle ci config and this causes the flake8 linter to fail in PRs that update example files...

@ogrisel
Copy link
Member Author

ogrisel commented Nov 2, 2020

I checked that this changes works as expected in this PR: #18729.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 2, 2020

Actually, let me simplify the script further.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 2, 2020

Ok it seems to work as it's supposed to. I will merge as soon as green to avoid breaking other PRs.

@ogrisel ogrisel merged commit b25d64f into scikit-learn:master Nov 2, 2020
@ogrisel ogrisel deleted the update-circle-linting-flake8-config branch November 2, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant