DOC Improve multiclass calibration example #18763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Nov 5, 2020
thomasjpfan
reviewed
Nov 6, 2020
Comment on lines
75
to
79
| # Below we plot a 2-simplex with arrows showing the change in predicted | ||
| # probabilities of the test samples. Each vertex of the simplex represents | ||
| # a perfectly predicted class (e.g., 1, 0, 0). The mid point | ||
| # inside the simplex represents predicting the three classes with equal | ||
| # probability (i.e., 1/3, 1/3, 1/3). Each arrow starts at the |
There was a problem hiding this comment.
While reading this, I find myself needing to sroll back and forth through the large code block to see the figure. Would moving some of this paragraph below the image and reference the image as "In the figure above" be okay here?
There was a problem hiding this comment.
Thanks, hopefully this is better
thomasjpfan
approved these changes
Nov 7, 2020
Comment on lines
+19
to
+20
| # Data | ||
| # ---- |
There was a problem hiding this comment.
This isn't rendering as a header, should we do the following instead?
Suggested change
| # Data | |
| # ---- | |
| # %% | |
| # Data | |
| # ---- |
|
Thanks @thomasjpfan , changes made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follows on from and closes #18729
What does this implement/fix? Explain your changes.
Make notebook style and expand explanations.
Any other comments?
cc @ogrisel @glemaitre