-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MNT Parallel platforms for cibuildwheel [cd build] #18818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT Parallel platforms for cibuildwheel [cd build] #18818
Conversation
This is really weird, when I define the 3 level build matrix, the matrix.python variable is undefined when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ogrisel for your PR!
LGTM.
This kind of PRs make me feel really happy. Let us wait for green in the Wheel builder
workflow, but looks nice.
.github/workflows/wheels.yml
Outdated
@@ -36,7 +36,7 @@ jobs: | |||
|
|||
# Build the wheels for Linux, Windows and macOS for Python 3.6 and newer | |||
build_wheels: | |||
name: Build wheels on ${{ matrix.os }} for Python ${{ matrix.python }} | |||
name: Build wheels cp${{ matrix.python }}-${{ matrix.platform_id }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this naming.
It is working now, is it not? |
Approximately, this should reduce the build process to 20 minutes, right? |
Yes I found my typo. |
I would say 25 min. |
Two (minor) questions @ogrisel:
Thank you! |
I am not sure it works as intended. I will debug it further. But I would not expect a big speed-up. It's more a protection if github actions workers are reconfigured to run on a 72 cores host with only 2 cores available via docker for instance.
That would be great indeed.
23 completed jobs in 28m 14s => nice! (instead of 50min for the total workflow previously). |
Merged :) I will rebase #18807 on top. |
The 32bit + 64bit sequential builds for Linux and Windows lasts for more than 40 min. The goal of this PR is to try to parallelize them by adjusting the github actions build matrix.