MNT use conda-forge for the pypy build on circle ci #18867
Conversation
|
Note uncomment the scheduled trigger once this PR is green on circle ci. |
|
It's working! bash is a hell... |
|
This PR reminds me the following: Would it be worth it to build the wheels for |
There was a problem hiding this comment.
For reference here is the build with pypy: https://app.circleci.com/pipelines/github/scikit-learn/scikit-learn/9715/workflows/6f86831c-7e63-42b3-9cd8-289c268b466c/jobs/126130
I like how this PR simplifies the pypy tests. LGTM
At some point we can move this to github actions and trigger with a [pypy build]. The workflow where we have to comment out the cron job in config.yml looks cumbersome.
| fi | ||
|
|
||
| source pypy-env/bin/activate | ||
| eval "$(conda shell.bash hook)" |
There was a problem hiding this comment.
Setting conda require quite a few steps..
There was a problem hiding this comment.
Yeah, that was really hell. circle ci must also be doing something weird when passing the bash commands to execute in the container because some setups that would work in my local docker would not work on circle ci. And I could never get micromamba setup to work at all on circle ci (while it would work well and fast in my local setup).
We could give it a try. But I would rather focus on updating the release doc for the existing wheel building setup first. |
|
Hum, the checkout step failed last night with: even though it worked when tested on this PR... |
Fixes: #18624
A patch for the upstream bug has been released on conda-forge but not yet an official release of PyPy on docker.