DOC Update maintainers' guide to use new wheel builder system #18878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Nov 23, 2020
ogrisel
reviewed
Nov 24, 2020
ogrisel
reviewed
Nov 24, 2020
thomasjpfan
reviewed
Nov 24, 2020
There was a problem hiding this comment.
The github checklist regarding
update dependencies and release tag at https://github.com/MacPython/scikit-learn-wheels
should be removed?
Since we are not longer using the |
Yes. |
|
I have applied the suggested changes 😉. |
…-learn into update_mainteiners_guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #18776.
What does this implement/fix? Explain your changes.
This PR updates the maintainers' guide to use the
Wheel builderworkflow.Any other comments?
CC @ogrisel.