Skip to content

CI Avoid Travis stuck on failure #19018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

CI Avoid Travis stuck on failure #19018

merged 1 commit into from
Dec 17, 2020

Conversation

alfaro96
Copy link
Member

Reference Issues/PRs

See #18782 (comment).

What does this implement/fix? Explain your changes.

This PR avoids Travis getting stuck on failure.

Any other comments?

CC @thomasjpfan and @ogrisel.

@alfaro96 alfaro96 added To backport PR merged in master that need a backport to a release branch defined based on the milestone. and removed Build / CI labels Dec 16, 2020
@alfaro96 alfaro96 added this to the 0.24 milestone Dec 16, 2020
@alfaro96 alfaro96 mentioned this pull request Dec 17, 2020
Closed
glemaitre
glemaitre approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I thought that we already had this when @ogrisel work on debugging the ARM build

ogrisel
ogrisel approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand why travis does not do that automatically by default, but it's a sane protection, especially given the fact that we have a limited compute time budget on travis.

@ogrisel ogrisel merged commit 3bca041 into scikit-learn:master Dec 17, 2020
@alfaro96 alfaro96 deleted the avoid_travis_stuck branch December 17, 2020 11:05
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 22, 2020
@alfaro96 @glemaitre
CI Avoid Travis stuck on failure (scikit-learn#19018)
505a419
@glemaitre glemaitre mentioned this pull request Dec 22, 2020
Merged
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@alfaro96 @glemaitre
CI Avoid Travis stuck on failure (scikit-learn#19018)
6edb211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@glemaitre glemaitre glemaitre approved these changes

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan

Assignees
No one assigned
Labels
Build / CI To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
0.24
Development

Successfully merging this pull request may close these issues.
3 participants
@alfaro96 @ogrisel @glemaitre