Skip to content

MNT catch warning for wminkowski #19100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MNT catch warning for wminkowski #19100

wants to merge 1 commit into from

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Jan 4, 2021 •
edited
Loading

Fixing the CI that fail due to 'wminkowski' DeprecationWarning raised in Scipy 1.6+

@cmarmo
Copy link
Contributor

cmarmo commented Jan 4, 2021

@glemaitre #19096 is meant to solve the same issue?

@glemaitre
Copy link
Member Author

Yep indeed. I think that we should do what @lorentzenchr is proposing (skipping the test) and do not handle the deprecation internally.

@glemaitre
Copy link
Member Author

Closing in favour of #19096

@glemaitre glemaitre closed this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build / CI module:neighbors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glemaitre @cmarmo