Skip to content

CI Reduce travis nightly load #19113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 6, 2021
Merged

CI Reduce travis nightly load #19113

merged 7 commits into from
Jan 6, 2021

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Jan 5, 2021 •
edited
Loading

In order to spare the limited build credits we have on travis, I was thinking we could reduce the number of cron builds we do there:

  • we should migrated the icc build to Azure but this can be done in a dedicated PR (TODO)
  • we can only do nightly linux/arm64 wheel build only for the latest Python version to spare resources: people who run scikit-learn bleeding edge builds are more likely to also run the latest Python version
  • we can remove the linux/arm64 cron test job that is redundant with the nightly linux/arm64 wheel build.

Note that the linux/arm64 test fail with scipy 1.6.0 which is handled in the dedicated issue: #19111.

@ogrisel
Copy link
Member Author

ogrisel commented Jan 5, 2021 •
edited
Loading

Another option would be to keep the cron schedule for all the the linux/arm64 wheel building jobs but reduce the frequency to weekly instead of daily for instance. This would allow to publish dev builds for linux/arm64 for all Python versions while sparing the travis credits and making sure that we have enough at release time.

thomasjpfan
thomasjpfan reviewed Jan 5, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option would be to keep the cron schedule for all the the linux/arm64 wheel building jobs but reduce the frequency to weekly instead of daily for instance.

I prefer reducing the frequency to weekly so we can have dev builds for the versions. It may also help catch some bugs before release, thus saving credits during release.

@alfaro96
Copy link
Member

alfaro96 commented Jan 5, 2021

Another option would be to keep the cron schedule for all the the linux/arm64 wheel building jobs but reduce the frequency to weekly instead of daily for instance.

I prefer reducing the frequency to weekly so we can have dev builds for the versions. It may also help catch some bugs before release, thus saving credits during release.

+1 about this solution.

ogrisel and others added 2 commits January 6, 2021 09:47
@ogrisel
Copy link
Member Author

ogrisel commented Jan 6, 2021 •
edited
Loading

I changed the cron job frequency to "weekly" in the https://travis-ci.com/github/scikit-learn/scikit-learn/settings admin UI

@ogrisel
Copy link
Member Author

ogrisel commented Jan 6, 2021

The [arm64] trigger still works well to only run the tests on linux/arm64: https://travis-ci.com/github/scikit-learn/scikit-learn/builds/212163072

@ogrisel
Copy link
Member Author

ogrisel commented Jan 6, 2021

I noticed that the [ci skip] marker is ignored by the Azure Pipelines jobs apparently (unrelated to this PR though).

alfaro96
alfaro96 approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@alfaro96 alfaro96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In short, we have changed the nightly job to weekly job (I have not admin rights in https://travis-ci.com/github/scikit-learn/scikit-learn/settings to check that, but I am pretty sure that @ogrisel has done it) and the arm64 job is redundant and we only want to manually trigger it with the [arm64] marker.

LGTM!

alfaro96
alfaro96 reviewed Jan 6, 2021
View reviewed changes
ogrisel
ogrisel commented Jan 6, 2021
View reviewed changes
thomasjpfan
thomasjpfan approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title Reduce travis nightly load CI Reduce travis nightly load Jan 6, 2021
@thomasjpfan thomasjpfan merged commit cbfe0ed into scikit-learn:master Jan 6, 2021
@ogrisel ogrisel deleted the reduce-travis-nightly-load branch January 6, 2021 15:11
@thomasjpfan
Copy link
Member

I noticed that the [ci skip] marker is ignored by the Azure Pipelines jobs apparently (unrelated to this PR though).

I opened #19134 to enable the [ci skip] marker in Azure Pipelines.

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jan 18, 2021
@ogrisel @thomasjpfan @glemaitre
CI Reduce travis nightly load (scikit-learn#19113)
110333f 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
jeremiedbb pushed a commit that referenced this pull request Jan 19, 2021
@ogrisel @thomasjpfan @jeremiedbb
CI Reduce travis nightly load (#19113)
0df2136 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfaro96 alfaro96 alfaro96 approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @alfaro96 @thomasjpfan