-
-
Notifications
You must be signed in to change notification settings - Fork 26k
[CI] Fix test failures in the nightly job #19114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you provide a link to the failing test? If we need to turn off xdist we can set |
The link to the failing test is here. Indeed, I was just testing if the problem was related with the parallel testing (and, indeed, it is). I turn off |
Ah its the Edit: I had solution somewhere in #17553 which I pull out to resolve the issue directly. |
I prefer the solution of #19118 (pre-downloading sequentially the datasets to avoid issues with pytest-xdist). |
+1 about the @thomasjpfan solution. Nevertheless, we still need to solve the remaining test failure. |
Indeed. There is still a remaining failure in |
What does this implement/fix? Explain your changes.
This PR fixes the remaining failures in the nightly job.