Skip to content

TST Skips test_compare_to_ELKI for arm #19115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Related to #19111

What does this implement/fix? Explain your changes.

Skips test on ARM so we do not block the 0.24.1 release.

@thomasjpfan thomasjpfan changed the title TST Skips test_compare_to_ELKI for arm [cd build] TST Skips test_compare_to_ELKI for arm Jan 5, 2021
Copy link
Member

@alfaro96 alfaro96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thomasjpfan!

LGTM.

@thomasjpfan
Copy link
Member Author

Now its failing for 32bit linux.

@ogrisel
Copy link
Member

ogrisel commented Jan 6, 2021

Now its failing for 32bit linux.

Interesting. This test is probably not very numerically stable in the first place. Or maybe numerical stability of scipy's minkowsky distance computation has been reduced in scipy 1.6.0.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge.

@ogrisel ogrisel merged commit 6902b10 into scikit-learn:master Jan 6, 2021
@ogrisel ogrisel added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Jan 6, 2021
@ogrisel ogrisel added this to the 0.24.1 milestone Jan 6, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jan 18, 2021
* TST Skips test for arm [cd build]

* CI Skip for 32bit linux [cd build]
jeremiedbb pushed a commit that referenced this pull request Jan 19, 2021
* TST Skips test for arm [cd build]

* CI Skip for 32bit linux [cd build]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:cluster To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants