Skip to content

[MRG] DOC fix ambiguous instruction #19125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2021
Merged

[MRG] DOC fix ambiguous instruction #19125

merged 2 commits into from
Jan 11, 2021

Conversation

Hephaest
Copy link
Contributor

@Hephaest Hephaest commented Jan 6, 2021 •
edited
Loading

Reference Issues/PRs

None, just document enhancement.

What does this implement/fix? Explain your changes.

I clearly mention to use cmd console (global environment) or Anaconda Prompt (in Anaconda) where to be executed the following commands:

$ SET DISTUTILS_USE_SDK=1
$ "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Auxiliary\Build\vcvarsall.bat" x64

I tried a lot and failed in PowerShell, and this could happen to others as well. So if they can know where to go, then they can avoid such a tricky problem.

Any other comments?

None

@glemaitre
Copy link
Member

cmd might be to restrictive if people are using Anaconda. I think this is call Anaconda Prompt under Windows. We might want to have a formulation that is broader in this regard.

@Hephaest
Copy link
Contributor Author

Hephaest commented Jan 6, 2021

@glemaitre

Thanks for the reply! Well, this was beyond my consideration, I thought here should be cmd by the context of the above paragraph:

Secondly, find out if you are running 64-bit or 32-bit Python. The building
command depends on the architecture of the Python interpreter. You can check
the architecture by running the following in cmd or powershell
console:

Given your suggestion, I will reorganise the sentence to make it more sense.

Thank you again!

@Hephaest Hephaest changed the title [MRG] DOC fix ambiguous instruction [WIP] DOC fix ambiguous instruction Jan 6, 2021
@Hephaest Hephaest changed the title [WIP] DOC fix ambiguous instruction [MRG] DOC fix ambiguous instruction Jan 7, 2021
@Hephaest
Copy link
Contributor Author

Hephaest commented Jan 7, 2021

Dear @glemaitre

I have modified the sentence as far as you suggest. Actually, the Anaconda Prompt is based off Command Prompt.

@glemaitre glemaitre merged commit aa1918c into scikit-learn:master Jan 11, 2021
@glemaitre
Copy link
Member

@Hephaest Thanks

glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Jan 18, 2021
@Hephaest @glemaitre
DOC Mention to use a command prompt in Windows install (scikit-learn#…
e3caae6 
…19125)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jeremiedbb pushed a commit that referenced this pull request Jan 19, 2021
@Hephaest @glemaitre @jeremiedbb
DOC Mention to use a command prompt in Windows install (#19125)
9f59c26 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hephaest @glemaitre