DOC Fix docstring of HalvingSearch estimators #19133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Of HalvingGridSearchCV and HalvingRandomSearchCV to refer to the respective classes
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jan 18, 2021
jeremiedbb
pushed a commit
that referenced
this pull request
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of HalvingGridSearchCV and HalvingRandomSearchCV to refer to the respective classes
What does this implement/fix? Explain your changes.
The docstrings for both new classes, for the refit parameter, refer to "this
GridSearchCVinstance". This PR fixes this to refer to the respective classes.Any other comments?
Presumably the code/docstrings where copied from GridSearchCV and this minor detail was overlooked.