CI Adds skipping to azure pipelines with commit message #19134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Jan 12, 2021
azure-pipelines.yml
Outdated
Comment on lines
189
to
193
| condition: | | ||
| and( | ||
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | ||
| ne(variables['Build.Reason'], 'Schedule') | ||
| ) |
There was a problem hiding this comment.
We should keep the dependency on linting success, no?
Suggested change
| condition: | | |
| and( | |
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | |
| ne(variables['Build.Reason'], 'Schedule') | |
| ) | |
| condition: | | |
| and( | |
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | |
| ne(variables['Build.Reason'], 'Schedule'), | |
| succeeded('linting') | |
| ) |
azure-pipelines.yml
Outdated
Comment on lines
168
to
172
| condition: | | ||
| and( | ||
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | ||
| ne(variables['Build.Reason'], 'Schedule') | ||
| ) |
There was a problem hiding this comment.
Suggested change
| condition: | | |
| and( | |
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | |
| ne(variables['Build.Reason'], 'Schedule') | |
| ) | |
| condition: | | |
| and( | |
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | |
| ne(variables['Build.Reason'], 'Schedule'), | |
| succeeded('linting') | |
| ) |
azure-pipelines.yml
Outdated
Comment on lines
146
to
150
| condition: | | ||
| and( | ||
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | ||
| ne(variables['Build.Reason'], 'Schedule') | ||
| ) |
There was a problem hiding this comment.
Suggested change
| condition: | | |
| and( | |
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | |
| ne(variables['Build.Reason'], 'Schedule') | |
| ) | |
| condition: | | |
| and( | |
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | |
| ne(variables['Build.Reason'], 'Schedule'), | |
| succeeded('linting') | |
| ) |
azure-pipelines.yml
Outdated
Comment on lines
98
to
102
| condition: | | ||
| and( | ||
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | ||
| ne(variables['Build.Reason'], 'Schedule') | ||
| ) |
There was a problem hiding this comment.
Suggested change
| condition: | | |
| and( | |
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | |
| ne(variables['Build.Reason'], 'Schedule') | |
| ) | |
| condition: | | |
| and( | |
| not(contains(dependencies['git_commit']['outputs']['commit.message'], '[ci skip]')), | |
| ne(variables['Build.Reason'], 'Schedule'), | |
| succeeded('linting') | |
| ) |
|
Updated PR by adding |
Yes, I think this was the case previously. |
|
Thanks for the fix, merged! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jan 18, 2021
jeremiedbb
pushed a commit
that referenced
this pull request
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use
[ci skip]in a commit message to skip azure pipelines in pull requests.