DOC Update installation instructions for macos/arm64 #19146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Jan 10, 2021
ogrisel
commented
Jan 11, 2021
|
Thanks @ogrisel |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jan 18, 2021
jeremiedbb
pushed a commit
that referenced
this pull request
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the simple and advanced installation instructions to mention the current lack of support of macos/arm64 when installing from pip / PyPI and instead point users to use conda-forge (both for installing the native m1 binary of scikit-learn and dependencies and building from source with the conda-forge version of the compilers).
I also rephrased / simplified related paragraphs and point users to use
miniforge/mambaforgewhich support more platforms than the anaconda and miniconda installers.Related to #19137 (to ship m1 / macos/arm64-native builds of scikit-learn on PyPI).