Skip to content

FIX/MNT do not support OOB score for multiclass-multioutput and additional refactoring #19162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jan 25, 2021
Merged

FIX/MNT do not support OOB score for multiclass-multioutput and additional refactoring #19162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
da306b0
MNT refactor OOB score in forest
glemaitre Jan 12, 2021
b923c58
Use scorer API to simplify code
glemaitre Jan 12, 2021
54c9bc1
some more work
glemaitre Jan 13, 2021
efde289
iter
glemaitre Jan 13, 2021
2b416d4
iter
glemaitre Jan 13, 2021
1fa6457
iter
glemaitre Jan 13, 2021
6f6c0d7
MNT remove temporary test
glemaitre Jan 13, 2021
02be5fe
TST add test for all supported classification
glemaitre Jan 13, 2021
4c83bb1
simplify regression scoring
glemaitre Jan 13, 2021
287920f
iter
glemaitre Jan 13, 2021
97b3546
TST update RandomTreeEmbedding test
glemaitre Jan 13, 2021
824dfdb
MNT revert setup cfg
glemaitre Jan 13, 2021
d0da8ba
TST remove wrong support for multiclass-multioutput
glemaitre Jan 13, 2021
24ea5e9
DOC add whats new entry
glemaitre Jan 13, 2021
7d8d765
iter
glemaitre Jan 13, 2021
dccfd5b
simplify code
glemaitre Jan 14, 2021
5b36e6a
add small comment
glemaitre Jan 14, 2021
9e5d567
Update doc/whats_new/v1.0.rst
glemaitre Jan 20, 2021
255d95f
add suggestions adrin
glemaitre Jan 21, 2021
a37ebb5
Update sklearn/ensemble/tests/test_forest.py
glemaitre Jan 21, 2021
4062d9c
partially address comment ogrisel
glemaitre Jan 21, 2021
bd808a3
finish review ogrisel
glemaitre Jan 21, 2021
3fbacfb
add a comment for supporting multioutpu-multiclass scoring strategy
glemaitre Jan 21, 2021
50243c0
Merge remote-tracking branch 'origin/main' into refactor_oob_trees
glemaitre Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions doc/whats_new/v1.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,16 @@ Changelog
- |Fix| Fixes incorrect multiple data-conversion warnings when clustering
boolean data. :pr:`19046` by :user:`Surya Prakash <jdsurya>`.

:mod:`sklearn.ensemble`
.......................

- |Fix| Do not allow to compute out-of-bag (OOB) score in
:class:`ensemble.RandomForestClassifier` and
:class:`ensemble.ExtraTreesClassifier` with multiclass-multioutput target
since scikit-learn does not provide any metric supporting this type of
target. Additional private refactoring was performed.
:pr:`19162` by :user:`Guillaume Lemaitre <glemaitre>`.

:mod:`sklearn.feature_extraction`
.................................

Expand Down
Loading