Skip to content

[DOC] Fix listing all available versions for the documentation #19163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2021
Merged

[DOC] Fix listing all available versions for the documentation #19163

merged 1 commit into from
Jan 13, 2021

Conversation

alfaro96
Copy link
Member

@alfaro96 alfaro96 commented Jan 13, 2021 •
edited
Loading

What does this implement/fix? Explain your changes.

This PR fixes the get_file_extension function in build_tools/circle/list_versions.py to solve the documentation failure.

Any other comments?

The command python build_tools/circle/list_versions.py outputs:

:orphan:

Available documentation for Scikit-learn
========================================

Web-based documentation is available for versions listed below:

* `Scikit-learn 1.0.dev0 (dev) documentation <https://scikit-learn.org/dev/>`_ (`ZIP 66.8 MB <https://scikit-learn.org/dev//_downloads/scikit-learn-docs.zip>`_)
* `Scikit-learn 0.24.0 (stable) documentation <https://scikit-learn.org/stable/>`_ (`PDF 53.7 MB <https://scikit-learn.org/stable//_downloads/scikit-learn-docs.pdf>`_)
* `Scikit-learn 0.23.2 documentation <https://scikit-learn.org/0.23/>`_ (`PDF 51.0 MB <https://scikit-learn.org/0.23//_downloads/scikit-learn-docs.pdf>`_)
* `Scikit-learn 0.22.2 documentation <https://scikit-learn.org/0.22/>`_ (`PDF 48.5 MB <https://scikit-learn.org/0.22//_downloads/scikit-learn-docs.pdf>`_)
* `Scikit-learn 0.21.3 documentation <https://scikit-learn.org/0.21/>`_ (`PDF 46.7 MB <https://scikit-learn.org/0.21//_downloads/scikit-learn-docs.pdf>`_)
* `Scikit-learn 0.20.4 documentation <https://scikit-learn.org/0.20/>`_ (`PDF 45.2 MB <https://scikit-learn.org/0.20//_downloads/scikit-learn-docs.pdf>`_)
* `Scikit-learn 0.19.2 documentation <https://scikit-learn.org/0.19/>`_ (`PDF 42.2 MB <https://scikit-learn.org/0.19//_downloads/scikit-learn-docs.pdf>`_)
* `Scikit-learn 0.18.2 documentation <https://scikit-learn.org/0.18/>`_ (`PDF 46.5 MB <https://scikit-learn.org/0.18//_downloads/scikit-learn-docs.pdf>`_)
* `Scikit-learn 0.17.1 documentation <https://scikit-learn.org/0.17/>`_ (`PDF 46.0 MB <https://scikit-learn.org/0.17//_downloads/scikit-learn-docs.pdf>`_)
* `Scikit-learn 0.16.1 documentation <https://scikit-learn.org/0.16/>`_ (`PDF 56.8 MB <https://scikit-learn.org/0.16//_downloads/scikit-learn-docs.pdf>`_)
* `Scikit-learn 0.15-git documentation <https://scikit-learn.org/0.15/>`_

@alfaro96 alfaro96 changed the title [FIX] Fix listing all available versions for the documentation [DOC] Fix listing all available versions for the documentation Jan 13, 2021
@glemaitre glemaitre merged commit a5d858c into scikit-learn:master Jan 13, 2021
@glemaitre
Copy link
Member

Thanks. I started to check and I was thinking it was due to a stable to pass through as a version.

@alfaro96 alfaro96 deleted the fix_ship_zip_html branch January 13, 2021 09:25
@alfaro96
Copy link
Member Author

The ZIP has been properly attached:

Captura de pantalla 2021-01-13 a las 11 27 52

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jan 18, 2021
@alfaro96 @glemaitre
MNT fix strict comparison in version listing (scikit-learn#19163)
957781f
jeremiedbb pushed a commit that referenced this pull request Jan 19, 2021
@alfaro96 @jeremiedbb
MNT fix strict comparison in version listing (#19163)
3d2bed6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfaro96 @glemaitre