Skip to content

Use stable numpy scipy release for [icc-build] and [arm64] on travis #19176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Jan 14, 2021

The scipy-dev builds have moved to Azure Pipelines and there is no
reason to not use stable versions of numpy and scipy to run the ICC
and ARM64 tests on travis.

This should fix the invalid wheel metadata failure observed on travis
which was already resolved on Azure Pipelines by using the legacy
pip dependency resolver for the scipy-dev build.

Here is an example of such a failure for the weekly travis ICC build:

https://travis-ci.com/github/scikit-learn/scikit-learn/jobs/471245966

The scipy-dev builds have moved to Azure Pipelines and there is no
reason to not use stable versions of numpy and scipy to run the ICC
and ARM64 tests on travis.

This should fix the invalid wheel metadata failure observed on travis
which was already resolved on Azure Pipelines by using the legacy
pip dependency resolver for the scipy-dev build.
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 9b2a3e8 into scikit-learn:master Jan 14, 2021
@ogrisel ogrisel deleted the fix-icc-build branch January 14, 2021 17:02
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jan 18, 2021
…is (scikit-learn#19176)

The scipy-dev builds have moved to Azure Pipelines and there is no
reason to not use stable versions of numpy and scipy to run the ICC
and ARM64 tests on travis.

This should fix the invalid wheel metadata failure observed on travis
which was already resolved on Azure Pipelines by using the legacy
pip dependency resolver for the scipy-dev build.
jeremiedbb pushed a commit that referenced this pull request Jan 19, 2021
…is (#19176)

The scipy-dev builds have moved to Azure Pipelines and there is no
reason to not use stable versions of numpy and scipy to run the ICC
and ARM64 tests on travis.

This should fix the invalid wheel metadata failure observed on travis
which was already resolved on Azure Pipelines by using the legacy
pip dependency resolver for the scipy-dev build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants