Skip to content

DOC Add link to video for contributing: Andreas video Volume 2 #19180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ranjanikrishnan
Copy link
Contributor

Reference Issues/PRs

Fixes #19170

What does this implement/fix? Explain your changes.

Updates the "Video Resources" section of the "Contributing" page documentation

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ranjanikrishnan , minor suggestion but lGMT

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@ranjanikrishnan
Copy link
Contributor Author

Thanks @ranjanikrishnan , minor suggestion but lGMT

@NicolasHug yes, that's better. Added the suggested change in description:)

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ranjanikrishnan !

@thomasjpfan thomasjpfan changed the title [MRG] #19170 Add link to video for contributing: Andreas video Volume 2 DOC Add link to video for contributing: Andreas video Volume 2 Jan 17, 2021
@thomasjpfan thomasjpfan merged commit 1fca00b into scikit-learn:master Jan 17, 2021
sujitahirrao added a commit to sujitahirrao/scikit-learn that referenced this pull request Jan 18, 2021
DOC Add link to video for contributing: Andreas video Volume 2 (scikit-learn#19180)
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jan 18, 2021
jeremiedbb pushed a commit that referenced this pull request Jan 19, 2021
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to video for contributing: Andreas video Volume 2
4 participants