Enhancement to Confusion Matrix Output Representation for improving readability #19012 #19190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Jan 17, 2021
sklearn/metrics/_classification.py
Outdated
| @@ -249,6 +249,10 @@ def confusion_matrix(y_true, y_pred, *, labels=None, sample_weight=None, | |||
| conditions or all the population. If None, confusion matrix will not be | |||
| normalized. | |||
|
|
|||
| pprint : bool, default=False | |||
sklearn/metrics/_classification.py
Outdated
| @@ -257,6 +261,14 @@ def confusion_matrix(y_true, y_pred, *, labels=None, sample_weight=None, | |||
| samples with true label being i-th class | |||
| and predicted label being j-th class. | |||
|
|
|||
| Or | |||
There was a problem hiding this comment.
This isn't valid numpydoc. The types need to be mentioned all on the first line.
There was a problem hiding this comment.
- Changed parameter name from pprint --> as_dict()
- Changed the Testing Function in test_classification.py
- Changed the Docstring for the function, added explaination of Series usage
Not sure about the numpydoc, I have changed it please review.
- Or should I mention it as --> tuple[ndarry, dict['true_class','pred_class']] ?
sklearn/metrics/_classification.py
Outdated
| @@ -249,6 +249,10 @@ def confusion_matrix(y_true, y_pred, *, labels=None, sample_weight=None, | |||
| conditions or all the population. If None, confusion matrix will not be | |||
| normalized. | |||
|
|
|||
| pprint : bool, default=False | |||
| Returns a confusion matrix in dict representation with labels as keys | |||
| ('true', 'pred') | |||
There was a problem hiding this comment.
It would be worth briefly noting the usage with pandas and unstack.
1. Changed parameter name from pprint --> as_dict() 2. Changed the Testing Function in test_classification.py 3. Tested 4. Changed the Docstring for the function, added explaination of Series usage
|
I guess this PR has stalled? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #19012
What does this implement/fix? Explain your changes.
When you have multiple levels you can have difficulty reading the ndarray, associating the levels with the True and Predicted values. It is an enhancement to the output of confusion matrix function, better representing the true and predicted values for multilevel classes.
Any other comments?