[MRG] Remove algorithm flag for PLS regression #19204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jan 19, 2021
There was a problem hiding this comment.
Thanks for the PR @BaptBillard
It seems that you have removed the parameter for _PLS which is the base class. We don't want that: the algorithm parameter is still relevant for PLSCannonical.
All we need is to remove the reference to algorithm in PLSRegression's docstring
Oh ok, sorry for my misunderstanding! I will change that as soon as possible! |
Remove 'algorithm' flag in PLSRegression docstring.
|
@NicolasHug it should be okay now! |
jeremiedbb
approved these changes
Jan 26, 2021
TomDLT
approved these changes
Jan 26, 2021
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
|
Merging with +2. Thanks! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues
Fixes #19197.
What does this implement/fix?
Problem using the flag
algorithm=svdin PLSRegression method because it shouldn't be possible to do so. The only other possible value wasalgorthm=nipals. Thus, by removing the 'svd' flag, only one value was available which implies that thealgorithmflag wasn't useful anymore.Any other comments?
The
algorithmflag has been removed from the code with all the associated checks (no function will check its value, the nipals algorithm will be used all the time). The documentation has been updated in the code and thesrtfile.