FIX Fix properly convert cv_results_ values to numpy array #19211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We discuss with @ogrisel and it is not critical for 0.24.1 but we will include it in the upcoming 0.24.2. |
thomasjpfan
reviewed
Jan 19, 2021
|
I don't think this needs to be release critical: it's an experimental API
|
thomasjpfan
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Move the whats new to 0.24.2. LGTM on my end.
@glemaitre easy review?
| for key, val in results.items(): | ||
| # each value is a list (as per evaluate_candidate's convention) | ||
| # we convert it to an array for consistency with the other keys | ||
| results[key] = np.asarray(val) |
There was a problem hiding this comment.
I updated this to use asarray so we do not make a copy if val is already an ndarray.
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Apr 19, 2021
…cikit-learn#19211) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
…cikit-learn#19211) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
…19211) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19203
Some values in the
cv_results_attribute of the SH estimators where lists instead of numpy arrays.CC @glemaitre as this might be release-critical?