FIX Fixes test_compare_to_elki failure #19221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran this on my raspberry pi (64 bit), but it would be nice to see this pass on travis-ci (arm) when we get credits again. |
|
So do you want to wait until next month to run the CI @thomasjpfan ? |
From a pure cost point of view, I would merge and see if it works on In the meantime, I am attempting to see if shippable can work. They seem to have free arm instances for open source projects: http://docs.shippable.com/platform/tutorial/workflow/run-ci-builds-on-arm/ |
adrinjalali
approved these changes
Jan 25, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #19111
What does this implement/fix? Explain your changes.
There was a very small numerical difference when using
pairwise_distanceson different archs.