Skip to content

MNT replace master with main #19237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 22, 2021
Merged

MNT replace master with main #19237

merged 3 commits into from
Jan 22, 2021

Conversation

adrinjalali
Copy link
Member

@adrinjalali adrinjalali commented Jan 22, 2021 •
edited
Loading

replacing instances of master with main when it comes to scikit-learn/scikit-learn repo

towards #17595

@glemaitre
Copy link
Member

glemaitre commented Jan 22, 2021 via email

@jeremiedbb
Copy link
Member

@adrinjalali the renaming closed ~40 PRs. Some of them were recent and approved.
I think it's due to that xxxxxx wants to merge 1 commit into scikit-learn:master from unknown repository.
I don't know what's going on. Does it mean the author deleted his fork after making the PR ?

glemaitre
glemaitre reviewed Jan 22, 2021
View reviewed changes
@adrinjalali
Copy link
Member Author

Yes, people tend to delete their forks or local branches and then it's lost. I'm not sure what we'd do with those even if this change hadn't closed them

glemaitre
glemaitre reviewed Jan 22, 2021
View reviewed changes
glemaitre
glemaitre approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrinjalali @glemaitre
fix imbalanced-learn
dde32ab 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre
Copy link
Member

@adrinjalali the renaming closed ~40 PRs. Some of them were recent and approved.
I think it's due to that xxxxxx wants to merge 1 commit into scikit-learn:master from unknown repository.
I don't know what's going on. Does it mean the author deleted his fork after making the PR ?

unknown repository means that it has been deleted from the user account (I recall something similar with @reshamas).
What would be interesting is to track these PRs and to put them at stalled if they are something to be addressed.

jeremiedbb
jeremiedbb approved these changes Jan 22, 2021
View reviewed changes
@adrinjalali
Copy link
Member Author

@reshamas 's docs also need to be updated for the sprint.

@amueller may want to re-record his tutorial 🙈

@cmarmo
Copy link
Contributor

cmarmo commented Jan 22, 2021 •
edited
Loading

What would be interesting is to track these PRs and to put them at stalled if they are something to be addressed.

I'm quickly checking them: a vast majority was already labeled as stalled... or need decision... it seems that github decided...

@adrinjalali @jeremiedbb
asv default branch is master
9cdd691 
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@jeremiedbb jeremiedbb mentioned this pull request Jan 22, 2021
Merged
@glemaitre
Copy link
Member

OK so we will be merging once the CIs are green.

@cmarmo cmarmo mentioned this pull request Jan 22, 2021
Merged
@adrinjalali adrinjalali merged commit 468c3f4 into scikit-learn:main Jan 22, 2021
@adrinjalali adrinjalali deleted the master-to-main branch January 22, 2021 14:19
glemaitre added a commit that referenced this pull request Jan 22, 2021
@adrinjalali @glemaitre @jeremiedbb
MNT replace master with main (#19237)
891605d 
* replace master with main

* fix imbalanced-learn

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

* asv default branch is `master`

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@adrinjalali @glemaitre @jeremiedbb
MNT replace master with main (scikit-learn#19237)
6af16bb 
* replace master with main

* fix imbalanced-learn

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

* asv default branch is `master`

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre added a commit that referenced this pull request Apr 28, 2021
@adrinjalali @glemaitre @jeremiedbb
MNT replace master with main (#19237)
54571bf 
* replace master with main

* fix imbalanced-learn

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

* asv default branch is `master`

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrinjalali @glemaitre @jeremiedbb @cmarmo