Skip to content

FIX nan bug in BaseLabelPropagation #19271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 1, 2021
Merged

FIX nan bug in BaseLabelPropagation #19271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a848ed7
Bug fix: Label propagation sometimes produces label_distributions tha…
ThuWangzw Jan 25, 2021
8be95eb
Merge remote-tracking branch 'upstream/main' into label_propagation_n…
ThuWangzw Jan 27, 2021
1c3da3f
add label propagation nan test
ThuWangzw Jan 27, 2021
bf402e6
pass lint
ThuWangzw Jan 27, 2021
86ec5b7
merge test
ThuWangzw Jan 27, 2021
0249155
Update sklearn/semi_supervised/tests/test_label_propagation.py
ThuWangzw Jan 30, 2021
b6ebeed
Update sklearn/semi_supervised/tests/test_label_propagation.py
ThuWangzw Jan 30, 2021
25bdbfd
Update sklearn/semi_supervised/tests/test_label_propagation.py
ThuWangzw Jan 30, 2021
d4edd8f
Merge remote-tracking branch 'upstream/main' into label_propagation_n…
ThuWangzw Jan 30, 2021
16e771a
Update sklearn/semi_supervised/tests/test_label_propagation.py
ThuWangzw Jan 30, 2021
8339918
pass lint
ThuWangzw Jan 30, 2021
65dc843
pass lint
ThuWangzw Jan 30, 2021
ef0aa0f
doc
ThuWangzw Jan 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/whats_new/v1.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ Changelog
for non-English characters. :pr:`18959` by :user:`Zero <Zeroto521>`
and :user:`wstates <wstates>`.

:mod:`sklearn.semi_supervised`
.................................

- |Fix| Avoid NaN during label propagation in
:class:`~sklearn.semi_supervised.LabelPropagation`.
:pr:`19271` by :user:`Zhaowei Wang <ThuWangzw>`.

Code and Documentation Contributors
-----------------------------------

Expand Down
1 change: 1 addition & 0 deletions sklearn/semi_supervised/_label_propagation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ def fit(self, X, y):
if self._variant == 'propagation':
normalizer = np.sum(
self.label_distributions_, axis=1)[:, np.newaxis]
normalizer[normalizer == 0] = 1
self.label_distributions_ /= normalizer
self.label_distributions_ = np.where(unlabeled,
self.label_distributions_,
Expand Down
12 changes: 8 additions & 4 deletions sklearn/semi_supervised/tests/test_label_propagation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,19 @@ def test_convergence_warning():
assert_no_warnings(mdl.fit, X, y)


def test_label_propagation_non_zero_normalizer():
@pytest.mark.parametrize("LabelPropagationCls",
[label_propagation.LabelSpreading,
label_propagation.LabelPropagation])
def test_label_propagation_non_zero_normalizer(LabelPropagationCls):
# check that we don't divide by zero in case of null normalizer
# non-regression test for
# https://github.com/scikit-learn/scikit-learn/pull/15946
# https://github.com/scikit-learn/scikit-learn/issues/9292
X = np.array([[100., 100.], [100., 100.], [0., 0.], [0., 0.]])
y = np.array([0, 1, -1, -1])
mdl = label_propagation.LabelSpreading(kernel='knn',
max_iter=100,
n_neighbors=1)
mdl = LabelPropagationCls(kernel='knn',
max_iter=100,
n_neighbors=1)
assert_no_warnings(mdl.fit, X, y)


Expand Down