Skip to content

TST Ignores PendingDeprecationWarning in tests #19301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2021
Merged

TST Ignores PendingDeprecationWarning in tests #19301

merged 1 commit into from
Jan 30, 2021

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Addresses #12327

What does this implement/fix? Explain your changes.

Ignores the pending deprecation warning when constructing np.matrix in tests.

Any other comments?

The other option would be to remove the usage of np.matrix in tests.

ogrisel
ogrisel reviewed Jan 30, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should update the 2 tests to check the numpy version and avoid testing for np.matrix-typed data in future versions of numpy where it's supposed to be removed.

The error message does not give a specific version of numpy.

ogrisel
ogrisel approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for merging as it is.

lorentzenchr
lorentzenchr approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorentzenchr lorentzenchr merged commit 38e6022 into scikit-learn:main Jan 30, 2021
@lorentzenchr lorentzenchr mentioned this pull request Jan 30, 2021
Closed
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@thomasjpfan @glemaitre
TST Ignores PendingDeprecationWarning in tests (scikit-learn#19301)
10f336a
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
@thomasjpfan @glemaitre
TST Ignores PendingDeprecationWarning in tests (#19301)
9784568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @ogrisel @lorentzenchr