FIX MultiOutputRegressor correctly ducktypes fitted estimators #19308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently placing this on 0.24.2, but I am okay with holding it for 1.0 as well. |
|
@thomasjpfan I'm also experiencing this issue with |
|
@alexottenwess-sp May you open an issue with a reproducible code example, so we can look into working out your issue with |
|
@thomasjpfan see #19357 |
Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
|
Thanks @thomasjpfan |
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Apr 19, 2021
…t-learn#19308) Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
…t-learn#19308) Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16549
What does this implement/fix? Explain your changes.
Checks the fitted
multioutput.estimators_forpredict.