Skip to content

ENH Checks n_features_in_ in discriminant_analysis #19342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2021
Merged

ENH Checks n_features_in_ in discriminant_analysis #19342

merged 2 commits into from
Feb 5, 2021

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Related to #19333

@thomasjpfan thomasjpfan mentioned this pull request Feb 3, 2021
Closed
47 tasks
lorentzenchr
lorentzenchr approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one comment/question.

ogrisel
ogrisel approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel ogrisel merged commit 23d8761 into scikit-learn:main Feb 5, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @ogrisel @lorentzenchr