Skip to content

DOC rename Birch to BIRCH in docs #19368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2021

Conversation

elateifsara
Copy link
Contributor

@elateifsara elateifsara commented Feb 6, 2021

Fixes #19248.

Rename Birch to BIRCH in user guide documentation

@glemaitre glemaitre changed the title Fix BIRCH mention in documentation DOC rename Birch to BIRCH in user guide documentation Feb 6, 2021
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both, this looks good

I think there are a few more occurrences that could be replaced:



examples/cluster/plot_birch_vs_minibatchkmeans.py:39:# Generate blobs to do a comparison between MiniBatchKMeans and Birch.
examples/cluster/plot_birch_vs_minibatchkmeans.py:48:# Compute clustering with Birch with and without the final clustering step
examples/cluster/plot_birch_vs_minibatchkmeans.py:58:    print("Birch %s as the final step took %0.2f seconds" % (
examples/cluster/plot_birch_vs_minibatchkmeans.py:78:    ax.set_title('Birch %s' % info)
examples/cluster/plot_cluster_comparison.py:146:        ('Birch', birch),
sklearn/cluster/_birch.py:327:    """Implements the Birch clustering algorithm.
sklearn/cluster/_birch.py:648:                    "Number of subclusters found (%d) by Birch is less "

@reshamas
Copy link
Member

reshamas commented Feb 6, 2021

#DataUmbrella sprint

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@NicolasHug NicolasHug changed the title DOC rename Birch to BIRCH in user guide documentation DOC rename Birch to BIRCH in docs Feb 6, 2021
@NicolasHug NicolasHug merged commit 28fa897 into scikit-learn:main Feb 6, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Birch should be called BIRCH
3 participants