EXA remove warning when setting yticks in permutation importances examples #19385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#DataUmbrella sprint |
lorentzenchr
reviewed
Feb 6, 2021
examples/inspection/plot_permutation_importance_multicollinear.py
Outdated
Show resolved
Hide resolved
glemaitre
reviewed
Feb 7, 2021
examples/inspection/plot_permutation_importance_multicollinear.py
Outdated
Show resolved
Hide resolved
|
Thanks @glemaitre, i will do that now |
…plot_permutation_importance_multicollinear.py and plot_permutation_importance.py
glemaitre
approved these changes
Feb 7, 2021
|
I checked the output, no warnings any more. Let's merge. |
|
Thanks, @glemaitre @lorentzenchr @thomasjpfan @ogrisel for the help, I'm really grateful. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Reference #19364
What does this implement/fix? Explain your changes.
Documentation fixes the error generated by importing FixedLocator from matplotlib.ticker, reorganizing the decorated yticks and ylabels
Any other comments?
cc: (pair programming) @Rukaya-lab