Fix ValueError on HistGradientBoostingRegressor with least_absolute_deviation loss function fit call with sample_weight parameter #19407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eviation loss function fit call with sample_weight parameter.
NicolasHug
approved these changes
Feb 9, 2021
sklearn/ensemble/_hist_gradient_boosting/tests/test_gradient_boosting.py
Outdated
Show resolved
Hide resolved
…oosting.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
|
Sorry, I forgot: we would also need an entry in |
I updated docs, but can a fix be a part of |
glemaitre
reviewed
Feb 9, 2021
sklearn/ensemble/_hist_gradient_boosting/tests/test_gradient_boosting.py
Show resolved
Hide resolved
You are right. I was about to merge but it makes sense to add the entry in |
glemaitre
approved these changes
Feb 9, 2021
I pushed commit with the change, but I can't see commit in PR |
|
Maybe there is some delay bew |
|
I closed and reponed hoping that GitHub would synchronize the PR. Magically, it worked so let's wait for the CI :) |
|
Thanks @vadim-ushtanit |
|
You are welcome! |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
…entBoosting (scikit-learn#19407) Co-authored-by: Vadim Ushtanit <vadim.ushtanit@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Apr 28, 2021
…entBoosting (#19407) Co-authored-by: Vadim Ushtanit <vadim.ushtanit@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #19400.