Skip to content

TST Replace the use of assert_warns messages in cluster/tests/ module #19437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 18, 2021

Conversation

zitorelova
Copy link
Contributor

Reference Issues/PRs

Partial fix for #19414

What does this implement/fix? Explain your changes.

Removes the use of assert(_warns(_message)/_no_warnings) in sklearn/cluster/tests/

Any other comments?

Part of solution to #19414

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zitorelova !

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small details, but +1 for merge once addressed.

@zitorelova
Copy link
Contributor Author

All comments addressed. Thanks for the feedback @ogrisel

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @zitorelova !

@jeremiedbb jeremiedbb merged commit 3217999 into scikit-learn:main Feb 18, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants