-
-
Notifications
You must be signed in to change notification settings - Fork 26k
TST Replace the use of assert_warns messages in cluster/tests/ module #19437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9450c33
to
03a218b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zitorelova !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small details, but +1 for merge once addressed.
All comments addressed. Thanks for the feedback @ogrisel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks @zitorelova !
Reference Issues/PRs
Partial fix for #19414
What does this implement/fix? Explain your changes.
Removes the use of assert(_warns(_message)/_no_warnings) in sklearn/cluster/tests/
Any other comments?
Part of solution to #19414