TST replace assert_raise_* by pytest.raises in linear_model module #19399 #19440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests/test_coordinate_descent.py, test_logistic.py, test_passive_aggressive.py, test_perceptron.py, test_ransac.py, test_ridge.py, test_sag.py, test_sgd.py
…ests/test_coordinate_descent.py, test_logistic.py, test_passive_aggressive.py, test_perceptron.py, test_ransac.py, test_ridge.py, test_sag.py, test_sgd.py: Fixed the test issues
1e33453 to
a62f1a4
Compare
…idge.py, test_sag.py, test_sgd.py, test_logistic.py
glemaitre
reviewed
Feb 12, 2021
glemaitre
reviewed
Feb 12, 2021
glemaitre
reviewed
Feb 12, 2021
glemaitre
reviewed
Feb 12, 2021
|
Thank you @glemaitre for all your help :). |
glemaitre
reviewed
Feb 12, 2021
|
I removed the Conflict and marked it as ( Resolved ) |
rth
reviewed
Feb 12, 2021
| Further details can be found in the appendix of [2]. | ||
|
|
There was a problem hiding this comment.
Also the above empty lines are intentional and shouldn't be removed.
ogrisel
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
+1 also on my side once the remaining comment by @rth has been addressed:
ogrisel
reviewed
Feb 12, 2021
| Further details can be found in the appendix of [2]. | ||
|
|
||
| Reference | ||
| --------- | ||
| .. [1] Zhu, Ji and Trevor J. Hastie. "Classification of gene microarrays by | ||
| penalized logistic regression". Biostatistics 5 3 (2004): 427-43. | ||
| https://doi.org/10.1093/biostatistics%2Fkxg046 | ||
|
|
There was a problem hiding this comment.
This line should be kept (I think). We are not that consistent in scikit-learn but I think more often than not, we have blank lines between references.
|
Thank you all for your help ^_^ |
|
#DataUmbrella |
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This PR is related to issue #14216
What does this implement/fix? Explain your changes.
Change assert_raises and assert_raises_regex to :
with pytest.raises(.....)
This is a part of Data Umbrella's sprint that was held in February 2021.