FIX RuntimeWarning by dividing by zero in test_sanity_check_pls_regression_constant_column_Y #19480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Feb 18, 2021
ogrisel
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #19334
What does this implement/fix? Explain your changes.
Fixes the
RuntimeWarningcaused bytest_sanity_check_pls_regression_constant_column_Yinsklearn/cross_decomposition/tests/test_pls.pyAny other comments?
The array
pls.y_loadings_looks like this:[[ 0. 0. 0. ]
[-0.43573004 0.58284789 0.21748017]
[ 0.13537388 -0.24864229 -0.18103859]]
Therefore, an error caused by division by zero occurs. I fixed the error but please let me know if this is a good solution or not.
#DataUmbrella sprint