Skip to content

TST replace assert_raise with pytest.raises in test_base.py #19500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2021
Merged

TST replace assert_raise with pytest.raises in test_base.py #19500

merged 1 commit into from
Feb 22, 2021

Conversation

azihna
Copy link
Contributor

@azihna azihna commented Feb 19, 2021

Reference Issues/PRs

Reference #14216

What does this implement/fix? Explain your changes.

Changed the assert_raises in tests/test_base.py to pytest.raises(...):

Any other comments?

#DataUmbrella
cc: @reshamas
@Mariam-ke

jeremiedbb
jeremiedbb approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @azihna

rth
rth approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit 1000d0a into scikit-learn:main Feb 22, 2021
@lorentzenchr lorentzenchr mentioned this pull request Mar 2, 2021
Closed
43 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azihna @rth @jeremiedbb