Skip to content

Use pytest instead of assert_warns/assert_no_warnings in sklearn/semi_supervised/tests. #19508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Use pytest instead of assert_warns/assert_no_warnings in sklearn/semi_supervised/tests. #19508

wants to merge 0 commits into from

Conversation

anashas
Copy link
Contributor

@anashas anashas commented Feb 20, 2021 •
edited
Loading

Reference Issues/PRs

References #19414

What does this implement/fix? Explain your changes.

remove assert_warns, assert_warns_message from semi_supervised/tests.
fixing flake8 errors.

Any other comments?

@ogrisel ogrisel changed the title Assertwarn Use pytest instead of assert_warn in sklearn/semi_supervised/tests. Feb 20, 2021
@ogrisel ogrisel changed the title Use pytest instead of assert_warn in sklearn/semi_supervised/tests. Use pytest instead of assert_no_warnings in sklearn/semi_supervised/tests. Feb 20, 2021
ogrisel
ogrisel reviewed Feb 20, 2021
View reviewed changes
@ogrisel ogrisel changed the title Use pytest instead of assert_no_warnings in sklearn/semi_supervised/tests. Use pytest instead of assert_warns/assert_no_warnings in sklearn/semi_supervised/tests. Feb 20, 2021
ogrisel
ogrisel approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the comment above has been addressed.

@anashas anashas closed this Feb 20, 2021
@anashas anashas mentioned this pull request Feb 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
module:metrics module:semi_supervised
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anashas @ogrisel