Skip to content

FEA Confusion matrix derived metrics #19556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 201 commits into
base: main
Choose a base branch
from
Open

FEA Confusion matrix derived metrics #19556

wants to merge 201 commits into from

Conversation

Pawel-Kranzberg
Copy link

@Pawel-Kranzberg Pawel-Kranzberg commented Feb 25, 2021 •
edited by thomasjpfan
Loading

Reference Issues/PRs

Continues #17265
Fixes #5516

What does this implement/fix? Explain your changes.

Add metrics.specificity_score and metrics.npv_score, based on metrics.fpr_tpr_fnr_tnr_scores from #17265

Any other comments?

samskruthi reddy padigepati and others added 21 commits May 18, 2020 21:59
@haochunchang
added a function with confusion matrix derived metrics (fpr, tpr, tnr…
9dbfbc8 
…, fnr)
@haochunchang
changed the true postive sum in the function
64a5a7b
@haochunchang
add print
523eaa0
@haochunchang
remove one print
b977216
@haochunchang
remove print statements
5a061ef
@haochunchang
add coauthors.
6493977 
Co-authored-by: samskruthi padigepati <https://github.com/ddhar1>
Co-authored-by: Divya Dhar<https://github.com/samskruthireddy>
@haochunchang
fix doc string outputs
141fa4a 
Co-authored-by: samskruthi padigepati <https://github.com/ddhar1>
Co-authored-by: Divya Dhar<https://github.com/samskruthireddy>
@haochunchang
pep8 test
9615ae8 
Co-authored-by: Divya Dhar  <https://github.com/ddhar1>
Co-authored-by: samskruthi padigepati <https://github.com/samskruthireddy>
@haochunchang
trivial
79e1562 
Co-authored-by: samskruthi padigepati <https://github.com/samskruthireddy>
@haochunchang
remove imported but unused flake8
8f21052
@haochunchang
to trigger test
3ffd830
@haochunchang
Take over PR scikit-learn#15522
fb73c6e 
Modify doc and add deprecation to position arg.
@haochunchang
Modify doc and zero-division in the weighted average.
c780053 
Add test for binary classification.
(Modify some lines to pass flake8)
@haochunchang
Add tests for binary, multiclass and empty prediction.
408c2db
@haochunchang
Add tpr_fpr_tnr_fnr_scores to test_common.py.
4adfe2e
@haochunchang
Remove pred_sum variable
53d6fd2
@haochunchang
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …
88c41af 
…into confusion-matrix-derived-metrics
@haochunchang
Fix linting
a5b5262
@haochunchang
Fix parameter documentation
f74fc10
@Pawel-Kranzberg
Add specificity_score as a single metric
44f8b7d
@Pawel-Kranzberg
Update __init__.py
56132a3
jnothman
jnothman reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specificity_score also needs adding to test_common

@Pawel-Kranzberg
Copy link
Author

image

@adrinjalali
Copy link
Member

@lorentzenchr would you be able to maybe have a look?

@lorentzenchr
Copy link
Member

From the long discussion in #5516, better ping @jnothman @amueller @glemaitre .

@adrinjalali adrinjalali mentioned this pull request May 1, 2024
Merged
@lorentzenchr
Copy link
Member

@Pawel-Kranzberg Could you please stop merging the main branch as long as there are no merge conflict? The reason is that it might hide discussions in Github and also generates notifications. And it should be in your interest that maintainers don't unsubscribe from this PR.

@JoshuaDBruton
Copy link

JoshuaDBruton commented Feb 26, 2025 •
edited
Loading

Hi everyone, I have need for specificity_score as well and it would be convenient if it worked like Recall and the others that are available. I have added it locally and was considering opening a PR but saw this one was open already.

Just seconding that this would be a useful thing.

I don't know if there are still plans to merge this PR? Should I open a second PR covering just specificity_score or is this still active?

@Pawel-Kranzberg
Copy link
Author

Hi everyone, I have need for specificity_score as well and it would be convenient if it worked like Recall and the others that are available. I have added it locally and was considering opening a PR but saw this one was open already.

Just seconding that this would be a useful thing.

I don't know if there are still plans to merge this PR? Should I open a second PR covering just specificity_score or is this still active?

From my perspective it is still active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

@jnothman jnothman Awaiting requested review from jnothman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
module:metrics Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Fall-out, Miss rate, specificity as metrics
10 participants
@Pawel-Kranzberg @glemaitre @jnothman @Scoodood @jeremiedbb @adrinjalali @lorentzenchr @JoshuaDBruton @cmarmo @haochunchang