Skip to content

ENH Adds final_estimator in html repr for Stacking* #19564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2021

Conversation

thomasjpfan
Copy link
Member

Adds final_estimator label to the html repr for Stacking*

main

Screen Shot 2021-02-25 at 4 04 17 PM

this PR

Screen Shot 2021-02-25 at 4 03 54 PM

Technical note: The visualblock was design such that parallel blocks will always show its children's names and serial blocks to always hide the names. This was because serial was design around pipeline, where showing the names would make the visualization too noisy. In this PR, I want one of the children to show it's name, so this PR wraps the final estimator with a parallel block which always show names.

CC @glemaitre

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an inline comment to explain the use of 'parallel' for final_estimator. Otherwise LGTM.

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre merged commit b8903da into scikit-learn:main Apr 9, 2021
thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Apr 19, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants