Skip to content

TST replaces assert_raise* by pytest.raises in model_selection/tests/test_validation.py #19592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mohaseeb
Copy link
Contributor

@mohaseeb mohaseeb commented Mar 1, 2021

Reference Issues/PRs

References #14216. This finalizes the work on PR #19381

What does this implement/fix? Explain your changes.

Replaces the use of assert_raise* with pytest.raises in model_selection/tests/test_validation.py

Any other comments?

#DataUmbrella
Mostly done by @cycks

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mohaseeb.

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mohaseeb !

@rth rth merged commit 5c0bbb0 into scikit-learn:main Mar 2, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants