ENH: add pre_dispatch parameter to cross_val_score function #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. I think it looks good. This will probably soon be replaced by #1787 but I don't see why we shouldn't merge this now. |
|
This is good. Merging. Thanks! |
|
Great. So we can close this one. |
|
@GaelVaroquaux did you actually merge it? I didn't see the commit. |
|
it's here 4e2bb00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter
pre_dispatchtocross_val_score. The same parameter is used inGridSearchCVhttps://github.com/scikit-learn/scikit-learn/blob/master/sklearn/grid_search.py#L524Tests are passing, docs arre build correctly and I checked for PEP8.
Feel free to disregard this PR if not of any use.