MNT move PolynomialFeatures from _data.py to _polynomial.py #19611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is changelog entry required here? |
sklearn/preprocessing/__init__.py
Outdated
Comment on lines
37
to
38
| from ._polynomial import SplineTransformer | ||
| from ._polynomial import PolynomialFeatures |
sklearn/preprocessing/_polynomial.py
Outdated
| @@ -427,3 +432,290 @@ def transform(self, X): | |||
| j for j in range(XBS.shape[1]) if (j + 1) % n_splines != 0 | |||
| ] | |||
| return XBS[:, indices] | |||
|
|
|||
|
|
|||
| class PolynomialFeatures(TransformerMixin, BaseEstimator): | |||
There was a problem hiding this comment.
I would place it before the splines.
Comment on lines
11
to
12
| from sklearn.preprocessing import KBinsDiscretizer, SplineTransformer | ||
| from sklearn.preprocessing import PolynomialFeatures |
There was a problem hiding this comment.
Suggested change
| from sklearn.preprocessing import KBinsDiscretizer, SplineTransformer | |
| from sklearn.preprocessing import PolynomialFeatures | |
| from sklearn.preprocessing import ( | |
| KBinsDiscretizer, PolynomialFeatures, SplineTransformer | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #19574
What does this implement/fix? Explain your changes.
I moved class PolynomialFeatures from _data.py to _polynomial.py as
mentioned in the issue. I also moved all tests relevant to PolynomialFeatures
from tests_data.py to tests_polynomial.py
Any other comments?
Please mention if I left something.