FIX RuntimeWarning by dividing by zero in test_iforest_with_uniform_data #19622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LSturtew Thanks for opening this PR. I’m very glad that you found an issue to work on. Does the RuntimeWarning stem from fit or predict? |
|
It stems from predict. |
|
I'd prefer to fix the cause of the runtime warning instead of removing the tests. |
|
@lorentzenchr I have updated the score calculations to fix the runtime warning. |
sklearn/ensemble/_iforest.py
Outdated
Comment on lines
457
to
458
| -np.divide(depths, denominator, np.ones_like(depths), | ||
| where=denominator != 0) |
There was a problem hiding this comment.
Suggested change
| -np.divide(depths, denominator, np.ones_like(depths), | |
| where=denominator != 0) | |
| # For a single training sample, denominator and depth are 0. | |
| # Therefore, we set the score manually to 1. | |
| -np.divide(depths, denominator, out=np.ones_like(depths), | |
| where=denominator != 0) |
There was a problem hiding this comment.
Please use the keyword argument explicitly, i.e. out=np.ones_like(...).
lorentzenchr
approved these changes
Mar 15, 2021
marrodion
pushed a commit
to marrodion/scikit-learn
that referenced
this pull request
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#19334
What does this implement/fix? Explain your changes.
The runtime error was in the test on a single row of data. The zero division error was due to the fact that the average path length between points was 0. It does not make sense to me to use the isolation forest algorithm on 1d data.
Any other comments?