TST Change assert from sklearn to pytest style in tests/test_multioutput.py #19663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Mar 11, 2021
sklearn/tests/test_multioutput.py
Outdated
| # ValueError when number of outputs is different | ||
| # for fit and score | ||
| y_new = np.column_stack((y1, y2)) | ||
| moc.fit(X, y) | ||
| assert_raises(ValueError, moc.score, X, y_new) | ||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
Could you please add a check on the message itself for this one. Then you can probably remove the inline comment above because it's going to be redundant with the check itself.
There was a problem hiding this comment.
Pushed new changes to amend this. Thanks @ogrisel.
|
@azihna looks good but you have merge conflicts :) |
|
@jeremiedbb The conflicts seem to be because of some deleted comments. I'd like to resolve them but I can't :) |
|
Well I just realized that you already submitted the exact same PR (#19618) and it was merged. We can close this PR. Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #14216
What does this implement/fix? Explain your changes.
Changed the assert_raises, assert_message, assert_warns in tests/test_multioutput.py to pytest.raises().